Fix lint issues with Chromoting for Android.

remoting/android/java/src/org/chromium/chromoting/Chromoting.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.accounts.Account;
 import android.accounts.AccountManager;
 import android.accounts.AccountManagerCallback;
 import android.accounts.AccountManagerFuture;
 import android.accounts.AuthenticatorException;
 import android.accounts.OperationCanceledException;
+import android.annotation.TargetApi;
 import android.app.ActionBar;
 import android.app.Activity;
 import android.app.AlertDialog;
 import android.app.ProgressDialog;
 import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.res.Configuration;
+import android.os.Build;
 import android.os.Bundle;
 import android.provider.Settings;
 import android.util.Log;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
 import android.widget.ArrayAdapter;
 import android.widget.ListView;
 import android.widget.Toast;
 
@@ skipping 60 matching lines @@
      * used to request the host list a second time.
      */
     boolean mTriedNewAuthToken;
 
     /** Shows a warning explaining that a Google account is required, then closes the activity. */
     private void showNoAccountsDialog() {
         AlertDialog.Builder builder = new AlertDialog.Builder(this);
         builder.setMessage(R.string.noaccounts_message);
         builder.setPositiveButton(R.string.noaccounts_add_account,
                 new DialogInterface.OnClickListener() {
+                    @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
                     @Override
                     public void onClick(DialogInterface dialog, int id) {
                         Intent intent = new Intent(Settings.ACTION_ADD_ACCOUNT);
                         intent.putExtra(Settings.EXTRA_ACCOUNT_TYPES,

[garykac, 2014/05/12 17:37:14]

Doesn't this code need a 
   if (Build.VERSION.SDK_INT >= ...
check around the EXTRA_ACCOUNT_TYPES as well?

[Lambros, 2014/05/12 20:39:29]

I'm not sure. It works fine on an older device with Android 4.0.3, and there's
no sign of any crash in the log.

I guess this is because EXTRA_ACCOUNT_TYPES is a compile-time integer constant,
and so the generated bytecode doesn't need to do a runtime field lookup, which
would throw an exception on older versions. All that happens is that the Intent
ends up with extra information that the older Android OS doesn't know about so
it is simply ignored.

If the check is needed, it is only for style reasons. I'm happy to defer
judgement on this.

[newt (away), 2014/05/13 04:04:47]

Correct. Constants on Android are typically static final, so their values are
inlined at compile time. This means this code won't crash at runtime on old
versions of Android, but could -- in theory -- fail in mysterious ways.

To suppress the warning, you can either use the @TargetApi annotation if the
code is only run on higher versions of Android, or if the warning doesn't
actually indicate a problem (which often seems to be the case with InlinedApi),
you can use @SuppressLint("InlinedApi"). I think the latter would actually be
appropriate here... unless this code path never runs on Android devices running
JB MR1 and below.

                                 new String[] { ACCOUNT_TYPE });
                         if (intent.resolveActivity(getPackageManager()) != null) {
                             startActivity(intent);
                         }
                         finish();
                     }
                 });
         builder.setNegativeButton(R.string.close, new DialogInterface.OnClickListener() {
                 @Override
                 public void onClick(DialogInterface dialog, int id) {
@@ skipping 322 matching lines @@
                 // Unreachable, but required by Google Java style and findbugs.
                 assert false : "Unreached";
         }
 
         if (dismissProgress && mProgressIndicator != null) {
             mProgressIndicator.dismiss();
             mProgressIndicator = null;
         }
     }
 }