third_party/WebKit/public/web/WebPlugin.h - Issue 2733083004: Emit error events if the loading of an object element failed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebPlugin.h

diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h

index 6e6403a7a6a5e5ce5129610d46044c0bbe83a7b6..94ef8a841fdedec8d5be8b4bc0794e729ee94fb6 100644

--- a/third_party/WebKit/public/web/WebPlugin.h

+++ b/third_party/WebKit/public/web/WebPlugin.h

@@ -237,7 +237,7 @@ class WebPlugin {

// Rotates the plugin's view of its content.

virtual void rotateView(RotationType type) {}

- virtual bool isPlaceholder() { return true; }

+ virtual bool isPlaceholder() { return false; }

Bernhard Bauer 2017/03/28 10:55:59 I don't think you need to change the default imple

George Joseph 2017/03/30 08:41:44 Done.

protected:

~WebPlugin() {}