Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebPlugin.h
diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h
index 6e6403a7a6a5e5ce5129610d46044c0bbe83a7b6..4d28e153cf22b5e3fb318f5c9d7433af57bcf9d5 100644
--- a/third_party/WebKit/public/web/WebPlugin.h
+++ b/third_party/WebKit/public/web/WebPlugin.h
@@ -237,10 +237,13 @@ class WebPlugin {
// Rotates the plugin's view of its content.
virtual void rotateView(RotationType type) {}
- virtual bool isPlaceholder() { return true; }
+ virtual bool isPlaceholder() { return placeholder; }
+ virtual void markAsErrorPlaceholder() { placeholder = true; }
+ virtual void unmarkAsErrorPlaceholder() { placeholder = false; }
protected:
~WebPlugin() {}
+ bool placeholder = false;
Bernhard Bauer 2017/03/27 09:20:27 WebPlugin is an interface; it shouldn't have membe
George Joseph 2017/03/28 10:08:31 Done.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698