Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/loadable_plugin_placeholder.h
diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h
index ea52ae9e5d68ab9b1e4418d250b90edc6828163d..a063c18db835557c6555cab374b7823bb9291378 100644
--- a/components/plugins/renderer/loadable_plugin_placeholder.h
+++ b/components/plugins/renderer/loadable_plugin_placeholder.h
@@ -45,7 +45,10 @@ class LoadablePluginPlaceholder : public PluginPlaceholderBase {
// When we load the plugin, use this already-created plugin, not a new one.
void SetPremadePlugin(content::PluginInstanceThrottler* throttler);
- void AllowLoading() { allow_loading_ = true; }
+ void AllowLoading() {
+ plugin()->unmarkAsErrorPlaceholder();
+ allow_loading_ = true;
+ }
protected:
LoadablePluginPlaceholder(content::RenderFrame* render_frame,

Powered by Google App Engine
This is Rietveld 408576698