Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10786)

Unified Diff: chrome/renderer/plugins/non_loadable_plugin_placeholder.cc

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
diff --git a/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc b/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
index 38e4349651bc64b07cbf98ae202cae5b5e6e6729..13f0575c8a833936464efcd5f67e0aa74fb7b8fa 100644
--- a/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
+++ b/chrome/renderer/plugins/non_loadable_plugin_placeholder.cc
@@ -33,8 +33,13 @@ NonLoadablePluginPlaceholder::CreateNotSupportedPlugin(
std::string html_data = webui::GetI18nTemplateHtml(template_html, &values);
+ plugins::PluginPlaceholder* plugin =
+ new plugins::PluginPlaceholder(render_frame, frame, params, html_data);
+
+ plugin->plugin()->markAsErrorPlaceholder();
+
// PluginPlaceholder will destroy itself when its WebViewPlugin is going away.
- return new plugins::PluginPlaceholder(render_frame, frame, params, html_data);
+ return plugin;
}
// static
@@ -55,6 +60,8 @@ plugins::PluginPlaceholder* NonLoadablePluginPlaceholder::CreateErrorPlugin(
plugins::PluginPlaceholder* plugin =
new plugins::PluginPlaceholder(render_frame, nullptr, params, html_data);
+ plugin->plugin()->markAsErrorPlaceholder();
+
content::RenderThread::Get()->Send(new ChromeViewHostMsg_CouldNotLoadPlugin(
plugin->routing_id(), file_path));
return plugin;

Powered by Google App Engine
This is Rietveld 408576698