Emit error events if the loading of an object element failed

components/plugins/renderer/loadable_plugin_placeholder.cc

Index: components/plugins/renderer/loadable_plugin_placeholder.cc
diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc
index 355dc7d6db392b4397b4218f32c40be11647d42e..5a99de1e953ac1a36daa2d6a543799fe0288af63 100644
--- a/components/plugins/renderer/loadable_plugin_placeholder.cc
+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc
@@ -71,7 +71,9 @@ LoadablePluginPlaceholder::LoadablePluginPlaceholder(
       premade_throttler_(nullptr),
       allow_loading_(false),
       finished_loading_(false),
-      weak_factory_(this) {}
+      weak_factory_(this) {
+  plugin()->markAsPlaceholder();

[tommycli, 2017/03/15 00:58:29]

Since some placeholders are temporary, and others are truly "error"
placeholders, I think this method should be renamed...

maybe markAsErrorPlaceholder? Also I think this method should only be called if
AllowLoading is false. This is tricky because currently AllowLoading is called
separately (see
https://cs.chromium.org/chromium/src/chrome/renderer/chrome_content_renderer_...)
from the constructor. It probably needs to be merged into the constructor call. 

I think to cover Android, NonLoadablePluginPlaceholder should also call this
method. That one should always call it since it's never loadable.

[George Joseph, 2017/03/22 00:04:09]

Done.

+}
 
 LoadablePluginPlaceholder::~LoadablePluginPlaceholder() {
 }