Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebPlugin.h
diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h
index 270ba343b527cfcf731395108c11fed020df0c0c..ee1d0dd08c44a94bc1694516b4a852588d742d04 100644
--- a/third_party/WebKit/public/web/WebPlugin.h
+++ b/third_party/WebKit/public/web/WebPlugin.h
@@ -239,8 +239,13 @@ class WebPlugin {
virtual bool CanRotateView() { return false; }
// Rotates the plugin's view of its content.
virtual void RotateView(RotationType type) {}
-
+ // Check whether a plugin can be interacted with. A positive return value
+ // means the plugin has not loaded and hence cannot be interacted with.
+ // The plugin could, however, load successfully later.
virtual bool IsPlaceholder() { return true; }
+ // Check whether a plugin failed to load, with there being no possibility of
+ // it loading later.
+ virtual bool IsErrorPlaceholder() { return false; }
protected:
~WebPlugin() {}
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698