Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: components/plugins/renderer/webview_plugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/plugins/renderer/plugin_placeholder.cc ('k') | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/webview_plugin.h
diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h
index 242592b20f06a8bcb7595b4da8ad9d2501a68540..ea61c9d978d517bc704faa1ca7e6679b54c4318c 100644
--- a/components/plugins/renderer/webview_plugin.h
+++ b/components/plugins/renderer/webview_plugin.h
@@ -55,6 +55,8 @@ class WebViewPlugin : public blink::WebPlugin,
// Called when the unobscured rect of the plugin is updated.
virtual void OnUnobscuredRectUpdate(const gfx::Rect& unobscured_rect) {}
+
+ virtual bool IsErrorPlaceholder() = 0;
};
// Convenience method to set up a new WebViewPlugin using |preferences|
@@ -84,6 +86,8 @@ class WebViewPlugin : public blink::WebPlugin,
v8::Local<v8::Object> V8ScriptableObject(v8::Isolate* isolate) override;
+ bool IsErrorPlaceholder() override;
+
void UpdateAllLifecyclePhases() override;
void Paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override;
« no previous file with comments | « components/plugins/renderer/plugin_placeholder.cc ('k') | components/plugins/renderer/webview_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698