third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html - Issue 2733083004: Emit error events if the loading of an object element failed

Unified Diff: third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html ('k') | third_party/WebKit/Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html

diff --git a/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html b/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html

new file mode 100644

index 0000000000000000000000000000000000000000..c8f91c27922c7698fc27b9f74b5dfe77803dfbb0

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html

@@ -0,0 +1,23 @@

+<html>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<body>

+<object type="image/gif" data="resources/apple.gif" onload="loadHandler()"

+ onerror="errorHandler()"></object>

+<script>

+var testobject = async_test("crbug.com/445557:error events aren't dispatched" +

+ " for <object> elements");

+function loadHandler() {

+ testobject.done();

+function errorHandler() {

+ setTimeout(function () {

Bernhard Bauer 2017/04/18 10:08:02 I think the timeout is in the wrong place here. Yo

George Joseph 2017/04/18 14:18:45 Done.

+ testobject.step(function() {

+ assert_true(false);

Bernhard Bauer 2017/04/18 10:08:02 I would use assert_unreached(<message>), as that c

George Joseph 2017/04/18 14:18:45 Done.

+ });

+ testobject.done();

Bernhard Bauer 2017/04/18 10:08:02 This call is also unnecessary.

George Joseph 2017/04/18 14:18:45 Done.

+ },0);

Bernhard Bauer 2017/04/18 10:08:02 Nit: space after comma.

George Joseph 2017/04/18 14:18:45 Done.

+};

+</script>

+</body>

+</html>