components/plugins/renderer/loadable_plugin_placeholder.cc - Issue 2733083004: Emit error events if the loading of an object element failed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.cc

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/loadable_plugin_placeholder.cc

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc

index 4f1303cbfa1456d732b629b572843ac6ee1ee31c..8621d3d6e7e5394cbe4225c0653b9d35e1036e05 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.cc

+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc

@@ -178,6 +178,10 @@ v8::Local<v8::Object> LoadablePluginPlaceholder::GetV8ScriptableObject(

return v8::Local<v8::Object>();

}

+bool LoadablePluginPlaceholder::IsErrorPlaceholder() {

+ return !allow_loading_;

void LoadablePluginPlaceholder::OnUnobscuredRectUpdate(

const gfx::Rect& unobscured_rect) {

DCHECK(content::RenderThread::Get());