Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebPlugin.h
diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h
index 6e6403a7a6a5e5ce5129610d46044c0bbe83a7b6..ae618fc3af8bc4c4c43e6ff02b7f1c89868dba55 100644
--- a/third_party/WebKit/public/web/WebPlugin.h
+++ b/third_party/WebKit/public/web/WebPlugin.h
@@ -236,8 +236,13 @@ class WebPlugin {
virtual bool canRotateView() { return false; }
// Rotates the plugin's view of its content.
virtual void rotateView(RotationType type) {}
-
+ // Check whether a plugin can be interacted with.A positive return value
Bernhard Bauer 2017/04/03 10:14:20 Nit: Space after period.
George Joseph 2017/04/04 23:37:41 Done.
+ // means the plugin has not loaded and hence cannot be interacted with.
+ // The plugin could ,however, load successfully later.
Bernhard Bauer 2017/04/03 10:14:20 Nit: swap comma and space (the first instance plz
George Joseph 2017/04/04 23:37:41 Done.
virtual bool isPlaceholder() { return true; }
+ // Check whether a plugin failed to load, with there being no possibility of
Bernhard Bauer 2017/04/03 10:14:20 Nit: collapse two spaces between "being" and "no"
George Joseph 2017/04/04 23:37:41 Done.
+ // it loading later.
+ virtual bool isErrorplaceholder() { return false; }
Bernhard Bauer 2017/04/03 10:14:20 Nit: isErrorPlaceholder (the CamelCase version of
George Joseph 2017/04/04 23:37:41 Done.
protected:
~WebPlugin() {}

Powered by Google App Engine
This is Rietveld 408576698