Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9310)

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/loadable_plugin_placeholder.h
diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h
index ea52ae9e5d68ab9b1e4418d250b90edc6828163d..0e101833cdc7aba9c1d3f3374ce076c5276b13eb 100644
--- a/components/plugins/renderer/loadable_plugin_placeholder.h
+++ b/components/plugins/renderer/loadable_plugin_placeholder.h
@@ -92,6 +92,8 @@ class LoadablePluginPlaceholder : public PluginPlaceholderBase {
v8::Isolate* isolate) const override;
void OnUnobscuredRectUpdate(const gfx::Rect& unobscured_rect) override;
Bernhard Bauer 2017/03/30 09:08:28 Nit: leave out the empty line here; the whole bloc
George Joseph 2017/03/30 22:58:03 Done.
+ bool isErrorPlaceholder() override;
+
// RenderFrameObserver methods:
void WasShown() override;

Powered by Google App Engine
This is Rietveld 408576698