Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/plugins/renderer/loadable_plugin_placeholder.cc ('K') | « third_party/WebKit/Source/web/WebPluginContainerImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebPlugin.h
diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h
index e805e94d7b926aa827ba0b08c9b0d4150b5f9f65..099e938b78acb721a407c9e23b655daf3019e426 100644
--- a/third_party/WebKit/public/web/WebPlugin.h
+++ b/third_party/WebKit/public/web/WebPlugin.h
@@ -227,10 +227,12 @@ class WebPlugin {
// Rotates the plugin's view of its content.
virtual void rotateView(RotationType type) {}
- virtual bool isPlaceholder() { return true; }
+ virtual bool isPlaceholder() { return placeholder; }
+ virtual void markAsPlaceholder() { placeholder = true; }
protected:
~WebPlugin() {}
+ bool placeholder = false;
};
} // namespace blink
« components/plugins/renderer/loadable_plugin_placeholder.cc ('K') | « third_party/WebKit/Source/web/WebPluginContainerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698