Emit error events if the loading of an object element failed

components/plugins/renderer/webview_plugin.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
 
 #include <list>
 #include <memory>
 
@@ skipping 87 matching lines @@
   void updateVisibility(bool) override {}
 
   blink::WebInputEventResult handleInputEvent(
       const blink::WebInputEvent& event,
       blink::WebCursorInfo& cursor_info) override;
 
   void didReceiveResponse(const blink::WebURLResponse& response) override;
   void didReceiveData(const char* data, int data_length) override;
   void didFinishLoading() override;
   void didFailLoading(const blink::WebURLError& error) override;
+  bool isPlaceholder() override;
+  void markAsErrorPlaceholder();

[Bernhard Bauer, 2017/03/28 10:55:59]

These two methods are not overrides of WebPlugin, so they should not be grouped
with isPlaceholder().

Coming to think of it, whether or not this is an error placeholder is really
defined by the client of this class, so instead of using a flag in here we could
make this a delegate method. PluginPlaceholderBase would implement the delegate
method to return false, and LoadablePluginPlaceholder would return
!allow_loading_.

[George Joseph, 2017/03/30 08:41:43]

Done.

+  void unmarkAsErrorPlaceholder();
 
  private:
   friend class base::DeleteHelper<WebViewPlugin>;
   WebViewPlugin(content::RenderView* render_view,
                 Delegate* delegate,
                 const content::WebPreferences& preferences);
   ~WebViewPlugin() override;
 
   // content::RenderViewObserver methods:
   void OnDestruct() override {}
@@ skipping 13 matching lines @@
   gfx::Rect rect_;
 
   blink::WebURLResponse response_;
   std::list<std::string> data_;
   std::unique_ptr<blink::WebURLError> error_;
   blink::WebString old_title_;
   bool finished_loading_;
   bool focused_;
   bool is_painting_;
   bool is_resizing_;
+  bool placeholder = false;

[Bernhard Bauer, 2017/03/28 10:55:59]

Member variables in Chromium style end with an underscore. (Although we can
remove this member, see above.)

[George Joseph, 2017/03/30 08:41:43]

Done.

 
   // A helper that handles interaction from WebViewPlugin's internal WebView.
   class WebViewHelper : public blink::WebViewClient,
                         public blink::WebFrameClient {
    public:
     WebViewHelper(WebViewPlugin* plugin,
                   const content::WebPreferences& preferences);
     ~WebViewHelper() override;
 
     blink::WebView* web_view() { return web_view_; }
@@ skipping 25 matching lines @@
     // Owned by us, deleted via |close()|.
     blink::WebView* web_view_;
   };
   WebViewHelper web_view_helper_;
 
   // Should be invalidated when destroy() is called.
   base::WeakPtrFactory<WebViewPlugin> weak_factory_;
 };
 
 #endif  // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_