third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html - Issue 2733083004: Emit error events if the loading of an object element failed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <body>

	5 <object type="image/gif" data="resources/apple.gif" onload="loadHandler()">

	6 </object>

	7 <script>

	8 var testobject = async_test("crbug.com/445557:error events aren't dispatched" +

	9 " for <object> elements");

	10 function loadHandler() {

	11 testobject.done();
	Bernhard Bauer 2017/04/13 15:48:42 Can you add an error handler that fails the test? Can you add an error handler that fails the test? And then maybe call testobject.done() via setTimeout(0), just to make sure the message loop gets flushed? If the error handler would fire later than that, we would miss it, but that's just not a thing that can be easily captured in tests. George Joseph 2017/04/16 18:22:29 Done. Show quoted text On 2017/04/13 15:48:42, Bernhard Bauer wrote: > Can you add an error handler that fails the test? And then maybe call > testobject.done() via setTimeout(0), just to make sure the message loop gets > flushed? If the error handler would fire later than that, we would miss it, but > that's just not a thing that can be easily captured in tests. Done.
	12 }

	13 </script>

	14 </body>

	15 </html>

OLD	NEW