third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html - Issue 2733083004: Emit error events if the loading of an object element failed

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <body>

	5 <object type="image/test" data="hello" id="object1" onerror="errorHandler()">

	6 <object type="image/gif" data="resources/apple.gif" id="objectimage"

	7 style="display:none" ></object>
	Bernhard Bauer 2017/04/09 20:32:24 This is formatted pretty badly. Please familiarize This is formatted pretty badly. Please familiarize yourself with the Web style guide at https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md and format your code accordingly. George Joseph 2017/04/13 11:30:48 Done. Show quoted text On 2017/04/09 20:32:24, Bernhard Bauer wrote: > This is formatted pretty badly. Please familiarize yourself with the Web style > guide at > https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md > and format your code accordingly. Done.
	8 <script>

	9 var gotErrorEvent=false;

	10 var testobject = async_test("crbug.com/445557:error events aren't dispatched" +

	11 " for <object> elements");

	12 function errorHandler() {

	13 document.getElementById("objectimage").onerror = imageErrorHandler;
	Bernhard Bauer 2017/04/09 20:32:24 I don't think you need to chain these two tests to I don't think you need to chain these two tests together. Maybe make two separate tests? George Joseph 2017/04/13 11:30:48 Done. Second test added. Show quoted text On 2017/04/09 20:32:24, Bernhard Bauer wrote: > I don't think you need to chain these two tests together. Maybe make two > separate tests? Done. Second test added.
	14 document.getElementById("objectimage").style.display="inline";

	15 testobject.step_timeout(function() {
	Bernhard Bauer 2017/04/09 20:32:24 Using timeouts isn't ideal (sometimes tests can le Using timeouts isn't ideal (sometimes tests can legitimately take longer, leading to flakiness, or the timeout can be too long, leading to long test times). Can you wait for the onload event instead? George Joseph 2017/04/13 11:30:48 Done. Please note that though the load event is be Show quoted text On 2017/04/09 20:32:24, Bernhard Bauer wrote: > Using timeouts isn't ideal (sometimes tests can legitimately take longer, > leading to flakiness, or the timeout can be too long, leading to long test > times). Can you wait for the onload event instead? Done. Please note that though the load event is being waited for in object-onload-placeholder.html, the load event is fired by the widget implementation(eg: the gif widget does emit a load event, a swf widget does not), so for the purpose of this change maybe a timeout is required to check that an error event is not fired by the new code. I will leave the decision to you. If any changes are required in the test scenario, please advice and I can make the necessary changes.
	16 if(gotErrorEvent != false)

	17 assert_false( gotErrorEvent , " Load Event Fired");
	Bernhard Bauer 2017/04/09 20:32:24 This could just be assert(!gotErrorEvent), no? This could just be assert(!gotErrorEvent), no? George Joseph 2017/04/13 11:30:48 Done. Code Removed. Show quoted text On 2017/04/09 20:32:24, Bernhard Bauer wrote: > This could just be assert(!gotErrorEvent), no? Done. Code Removed.
	18 else

	19 testobject.done();

	20 },3000);

	21 };

	22 function imageErrorHandler() {

	23 gotErrorEvent=true;

	24 }

	25 </script>

	26 </body>

	27 </html>

OLD	NEW

« no previous file with comments | « components/plugins/renderer/webview_plugin.cc ('k') | third_party/WebKit/Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »