Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 } 421 }
422 422
423 bool HTMLPlugInElement::hasCustomFocusLogic() const { 423 bool HTMLPlugInElement::hasCustomFocusLogic() const {
424 return !useFallbackContent(); 424 return !useFallbackContent();
425 } 425 }
426 426
427 bool HTMLPlugInElement::isPluginElement() const { 427 bool HTMLPlugInElement::isPluginElement() const {
428 return true; 428 return true;
429 } 429 }
430 430
431 bool HTMLPlugInElement::isErrorplaceholder() {
432 if (pluginWidget() && (pluginWidget()->isPluginContainer()) &&
Bernhard Bauer 2017/04/05 09:56:20 Nit: Parentheses around the individual expressions
George Joseph 2017/04/09 00:41:37 Done.
433 ((pluginWidget()->isErrorplaceholder())))
434 return true;
435 return false;
436 }
437
431 void HTMLPlugInElement::disconnectContentFrame() { 438 void HTMLPlugInElement::disconnectContentFrame() {
432 HTMLFrameOwnerElement::disconnectContentFrame(); 439 HTMLFrameOwnerElement::disconnectContentFrame();
433 setPersistedPluginWidget(nullptr); 440 setPersistedPluginWidget(nullptr);
434 } 441 }
435 442
436 bool HTMLPlugInElement::layoutObjectIsFocusable() const { 443 bool HTMLPlugInElement::layoutObjectIsFocusable() const {
437 if (HTMLFrameOwnerElement::supportsFocus() && 444 if (HTMLFrameOwnerElement::supportsFocus() &&
438 HTMLFrameOwnerElement::layoutObjectIsFocusable()) 445 HTMLFrameOwnerElement::layoutObjectIsFocusable())
439 return true; 446 return true;
440 447
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 657
651 void HTMLPlugInElement::lazyReattachIfNeeded() { 658 void HTMLPlugInElement::lazyReattachIfNeeded() {
652 if (!useFallbackContent() && needsPluginUpdate() && layoutObject() && 659 if (!useFallbackContent() && needsPluginUpdate() && layoutObject() &&
653 !isImageType()) { 660 !isImageType()) {
654 lazyReattachIfAttached(); 661 lazyReattachIfAttached();
655 setPersistedPluginWidget(nullptr); 662 setPersistedPluginWidget(nullptr);
656 } 663 }
657 } 664 }
658 665
659 } // namespace blink 666 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698