third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html - Issue 2733083004: Emit error events if the loading of an object element failed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/plugins/renderer/webview_plugin.cc ('k') | third_party/WebKit/Source/core/html/HTMLObjectElement.cpp » ('j') | third_party/WebKit/public/web/WebPlugin.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <body>

	5 <object type="image/test" data="hello" id="object1"

	6 onerror="errorHandler()"></object>
	Bernhard Bauer 2017/03/31 09:25:20 This line should be indented four spaces (similar This line should be indented four spaces (similar to C++ code; it's a broken continuation from the previous line). I think you can also break right before the closing </object> tag. George Joseph 2017/04/03 00:22:34 Done. Show quoted text On 2017/03/31 09:25:20, Bernhard Bauer wrote: > This line should be indented four spaces (similar to C++ code; it's a broken > continuation from the previous line). I think you can also break right before > the closing </object> tag. Done.
	7 <script>

	8 var testobject = async_test("crbug.com/445557:error events"
	Bernhard Bauer 2017/03/31 09:25:20 This seems like it's shorter than 80 characters no This seems like it's shorter than 80 characters now. The general rule is fit everything into 80 characters, so I think you can do: var testobject = async_test("crbug.com/445557:error events aren't dispatched" + " for <object> elements"); George Joseph 2017/04/03 00:22:34 Done. Show quoted text On 2017/03/31 09:25:20, Bernhard Bauer wrote: > This seems like it's shorter than 80 characters now. The general rule is fit > everything into 80 characters, so I think you can do: > > var testobject = async_test("crbug.com/445557:error events aren't dispatched" + > " for <object> elements"); Done.
	9 + "aren't dispatched for <object> elements");

	10 function errorHandler() {

	11 testobject.done();

	12 };

	13 </script>

	14 </body>

	15 </html>

OLD	NEW