Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2732973006: Mark new debugging stuff as flaky as it fails on mac/win/whatnot (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark new debugging stuff as flaky as it fails on mac/win/whatnot BUG= Committed: https://github.com/dart-lang/sdk/commit/067b377a3c011cf630a15367f5d1d24a5519919e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/kernel/testcases/strong-mode/call.baseline.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jensj
tbr. I will investigate further.
3 years, 9 months ago (2017-03-07 09:34:47 UTC) #2
jensj
Committed patchset #1 (id:1) manually as 067b377a3c011cf630a15367f5d1d24a5519919e (presubmit successful).
3 years, 9 months ago (2017-03-07 09:35:00 UTC) #4
Cutch
On 2017/03/07 09:35:00, jensj wrote: > Committed patchset #1 (id:1) manually as > 067b377a3c011cf630a15367f5d1d24a5519919e (presubmit ...
3 years, 9 months ago (2017-03-07 17:19:10 UTC) #5
jensj
3 years, 9 months ago (2017-03-08 07:10:16 UTC) #6
Message was sent while issue was closed.
It was revised in https://codereview.chromium.org/2734133003/.

Bugs reported are
https://github.com/dart-lang/sdk/issues/28978
https://github.com/dart-lang/sdk/issues/28975

On top of that (not reported as it isn't really a 'bug' per se) is that
snapshots doesn't include source and the generated source isn't 1-to-1 (messing
with expected column numbers).

Powered by Google App Engine
This is Rietveld 408576698