Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 2732973004: clang/plugin: Make auto raw check default in FindBadConstructs plugin. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "FindBadConstructsAction.h" 5 #include "FindBadConstructsAction.h"
6 6
7 #include "clang/AST/ASTConsumer.h" 7 #include "clang/AST/ASTConsumer.h"
8 #include "clang/Frontend/FrontendPluginRegistry.h" 8 #include "clang/Frontend/FrontendPluginRegistry.h"
9 9
10 #include "FindBadConstructsConsumer.h" 10 #include "FindBadConstructsConsumer.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 options_.enforce_in_thirdparty_webkit = true; 51 options_.enforce_in_thirdparty_webkit = true;
52 } else if (args[i] == "check-enum-last-value") { 52 } else if (args[i] == "check-enum-last-value") {
53 // TODO(tsepez): Enable this by default once http://crbug.com/356815 53 // TODO(tsepez): Enable this by default once http://crbug.com/356815
54 // and http://crbug.com/356816 are fixed. 54 // and http://crbug.com/356816 are fixed.
55 options_.check_enum_last_value = true; 55 options_.check_enum_last_value = true;
56 } else if (args[i] == "no-realpath") { 56 } else if (args[i] == "no-realpath") {
57 options_.no_realpath = true; 57 options_.no_realpath = true;
58 } else if (args[i] == "check-ipc") { 58 } else if (args[i] == "check-ipc") {
59 options_.check_ipc = true; 59 options_.check_ipc = true;
60 } else if (args[i] == "check-auto-raw-pointer") { 60 } else if (args[i] == "check-auto-raw-pointer") {
61 options_.check_auto_raw_pointer = true; 61 // This flag is deprecated and will be removed once Chromium builds aren't
62 // using it. http://crbug.com/554600.
62 } else { 63 } else {
63 parsed = false; 64 parsed = false;
64 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n"; 65 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
65 } 66 }
66 } 67 }
67 68
68 return parsed; 69 return parsed;
69 } 70 }
70 71
71 } // namespace chrome_checker 72 } // namespace chrome_checker
72 73
73 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( 74 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
74 "find-bad-constructs", 75 "find-bad-constructs",
75 "Finds bad C++ constructs"); 76 "Finds bad C++ constructs");
OLDNEW
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698