Update test status for Firefox 52/Issue 28983

Update test status for Firefox 52/Issue 28983

BUG=

Committed: https://github.com/dart-lang/sdk/commit/8d5015556e62316cc81e953c49ec3a58c3c27050

[Alan Knight, 2017-03-08 00:52:22]

alanknight@google.com changed reviewers:
+ sigmund@google.com

[Alan Knight, 2017-03-08 00:52:23]

TBR

[Alan Knight, 2017-03-08 00:52:54]

Description was changed from

==========
Update test status for Firefox 52/Issue 28983

BUG=
==========

to

==========
Update test status for Firefox 52/Issue 28983

BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8d5015556e62316cc81e953c49ec3a58c3c27050
==========

[Alan Knight, 2017-03-08 00:52:55]

Committed patchset #1 (id:1) manually as
8d5015556e62316cc81e953c49ec3a58c3c27050 (presubmit successful).

[Bill Hesse, 2017-03-08 09:29:22]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-03-08 09:29:23]

LGTM.

The status file changes like
-LayoutTests/fast/css-grid-layout/display-grid-set-get_t01: RuntimeError #
Please triage this failure
+LayoutTests/fast/css-grid-layout/display-grid-set-get_t01: Pass, RuntimeError #
Issue 28983
 
should instead be done by moving these RuntimeError statuses from the [
$compiler == dart2js && $runtime == ff && $system == windows ] section to the [
$compiler == dart2js && $runtime == ff && $system != windows ] section.

I will fix this in a new CL

https://codereview.chromium.org/2732963006/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/2732963006/diff/1/tests/html/html.status#newc...
tests/html/html.status:333: messageevent_test: Pass, RuntimeError # Issue 28983
If these are only failing on windows ff, you should make a separate section for
them, and mark them as RuntimeError there.

[Bill Hesse, 2017-03-08 10:02:26]

I meant from the [
$compiler == dart2js && $runtime == ff ] section to the [
$compiler == dart2js && $runtime == ff && $system != windows ] section.

I have now updated firefox on linux as well, so these should just be removed.
I did this change to the co19-dart2js.status file, but not the others.


On 2017/03/08 09:29:23, Bill Hesse wrote:
> LGTM.
> 
> The status file changes like
> -LayoutTests/fast/css-grid-layout/display-grid-set-get_t01: RuntimeError #
> Please triage this failure
> +LayoutTests/fast/css-grid-layout/display-grid-set-get_t01: Pass, RuntimeError
#
> Issue 28983
>  
> should instead be done by moving these RuntimeError statuses from the [
> $compiler == dart2js && $runtime == ff && $system == windows ] section to the
[
> $compiler == dart2js && $runtime == ff && $system != windows ] section.
> 
> I will fix this in a new CL
> 
> https://codereview.chromium.org/2732963006/diff/1/tests/html/html.status
> File tests/html/html.status (right):
> 
>
https://codereview.chromium.org/2732963006/diff/1/tests/html/html.status#newc...
> tests/html/html.status:333: messageevent_test: Pass, RuntimeError # Issue
28983
> If these are only failing on windows ff, you should make a separate section
for
> them, and mark them as RuntimeError there.