third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js - Issue 2732923002: Add fromSurface optional parameter to devtools Page.CaptureScreenshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

Issue 2732923002: Add fromSurface optional parameter to devtools Page.CaptureScreenshot (Closed)

Patch Set: Remove switches include Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/browser_protocol.json ('K') | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

index 5851b84651c808e332d08b0b55f5ac5ac0c3ed17..f9db77e1d9dfd5deb0f9881022e81cba9962218b 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

@@ -43,12 +43,13 @@ SDK.ScreenCaptureModel = class extends SDK.SDKModel {

/**

* @param {string} format

* @param {number} quality

+ * @param {boolean|undefined} fromSurface

dgozman 2017/03/08 19:21:37 Let's remove this parameter, and always pass false

dvallet 2017/03/09 06:19:47 Done.

* @return {!Promise<?string>}

- captureScreenshot(format, quality) {

+ captureScreenshot(format, quality, fromSurface) {

var fulfill;

var promise = new Promise(callback => fulfill = callback);

- this._agent.captureScreenshot(format, quality, (error, content) => {

+ this._agent.captureScreenshot(format, quality, fromSurface, (error, content) => {

if (error)

console.error(error);

fulfill(error ? null : content);