third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js - Issue 2732923002: Add fromSurface optional parameter to devtools Page.CaptureScreenshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

Issue 2732923002: Add fromSurface optional parameter to devtools Page.CaptureScreenshot (Closed)

Patch Set: Remove switches include Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/browser_protocol.json ('K') | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

index 34e83066b32f0ef18181e25324bbedf32384a6fb..200f54aad3390e4c6242caf954c9a58d73ba48b5 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

@@ -652,7 +652,7 @@ Emulation.DeviceModeModel = class {

}));

promises.push(this._target.emulationAgent().setVisibleSize(

Math.floor(scaledPageSize.width), Math.floor(scaledPageSize.height)));

- Promise.all(promises).then(() => screenCaptureModel.captureScreenshot('png', 100)).then(content => {

+ Promise.all(promises).then(() => screenCaptureModel.captureScreenshot('png', 100, false)).then(content => {

this._target.emulationAgent().setVisibleSize(this._emulatedPageSize.width, this._emulatedPageSize.height);

this._target.emulationAgent().resetViewport();

callback(content);