Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: headless/public/util/protocol_handler_request_id_browsertest.cc

Issue 2732873003: Revert of Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/chromium.linux.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/protocol_handler_request_id_browsertest.cc
diff --git a/headless/public/util/protocol_handler_request_id_browsertest.cc b/headless/public/util/protocol_handler_request_id_browsertest.cc
index d6bbdffa5fc6896fd5e2eb872b78090fb4be5e08..986bf1f1298e8c2b67327cfca53885cc8da72e6d 100644
--- a/headless/public/util/protocol_handler_request_id_browsertest.cc
+++ b/headless/public/util/protocol_handler_request_id_browsertest.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/run_loop.h"
-#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/test/browser_test.h"
#include "headless/public/devtools/domains/network.h"
#include "headless/public/devtools/domains/page.h"
@@ -170,24 +168,11 @@
public page::Observer {
public:
void RunDevTooledTest() override {
- if (content::IsBrowserSideNavigationEnabled()) {
- // TODO: get this working with PlzNavigate.
- // See discussion on https://codereview.chromium.org/2695923010/
- FinishAsynchronousTest();
- return;
- }
-
EXPECT_TRUE(embedded_test_server()->Start());
devtools_client_->GetPage()->AddObserver(this);
devtools_client_->GetPage()->Enable();
-
- base::RunLoop run_loop;
devtools_client_->GetNetwork()->AddObserver(this);
- devtools_client_->GetNetwork()->Enable(run_loop.QuitClosure());
- base::MessageLoop::ScopedNestableTaskAllower nest_loop(
- base::MessageLoop::current());
- run_loop.Run();
-
+ devtools_client_->GetNetwork()->Enable();
devtools_client_->GetPage()->Navigate("http://foo.com/index.html");
}
« no previous file with comments | « no previous file | testing/buildbot/chromium.linux.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698