Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 273283002: Sync: Do not generate non-UTF8 names for delete directives. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
haitaol1, Nicolas Zea, awong
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, erikwright+watch_chromium.org, browser-components-watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Sync: Do not generate non-UTF8 names for delete directives. BUG=371184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270035

Patch Set 1 #

Patch Set 2 : adapt to base namespace change in r268754 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M base/rand_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/delete_directive_handler.cc View 2 chunks +10 lines, -1 line 0 comments Download
M sync/internal_api/write_node.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
zea/haitaol: PTAL ajwong: base/ OWNERS please. It's just updating comments.
6 years, 7 months ago (2014-05-10 02:56:54 UTC) #1
awong
base OWNERS lgtm
6 years, 7 months ago (2014-05-10 02:59:47 UTC) #2
haitaol1
lgtm
6 years, 7 months ago (2014-05-12 16:09:43 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-12 19:00:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/273283002/1
6 years, 7 months ago (2014-05-12 19:00:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 23:06:12 UTC) #6
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 7 months ago (2014-05-12 23:10:37 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-12 23:13:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/273283002/20001
6 years, 7 months ago (2014-05-12 23:14:49 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 03:57:42 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 05:56:22 UTC) #11
Message was sent while issue was closed.
Change committed as 270035

Powered by Google App Engine
This is Rietveld 408576698