Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/js_backend/patch_resolver.dart

Issue 2732793002: Add NativeDataResolver (Closed)
Patch Set: Cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/native_data.dart ('k') | pkg/compiler/lib/src/js_emitter/native_emitter.dart » ('j') | pkg/compiler/lib/src/patch_parser.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/patch_resolver.dart
diff --git a/pkg/compiler/lib/src/js_backend/patch_resolver.dart b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
index fc836c379178f0b4b28fbaebc96f3daa821e4364..0dfd302191f10ccbfc9ba88b22a7cc28b9adf2f8 100644
--- a/pkg/compiler/lib/src/js_backend/patch_resolver.dart
+++ b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
@@ -33,7 +33,7 @@ class PatchResolverTask extends CompilerTask {
});
checkMatchingPatchSignatures(element, patch);
element = patch;
- } else if (!compiler.backend.nativeData.isJsInterop(element)) {
Johnni Winther 2017/03/04 16:34:29 We don't end up here if [element] is js interop.
+ } else {
reporter.reportErrorMessage(
element, MessageKind.PATCH_EXTERNAL_WITHOUT_IMPLEMENTATION);
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/native_data.dart ('k') | pkg/compiler/lib/src/js_emitter/native_emitter.dart » ('j') | pkg/compiler/lib/src/patch_parser.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698