Add NativeDataResolver

pkg/compiler/lib/src/js_backend/native_data.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library js_backend.native_data;
 
 import '../common.dart';
 import '../elements/elements.dart'
     show
         ClassElement,
         Element,
         FieldElement,
         FunctionElement,
+        LibraryElement,
         MemberElement,
         MethodElement;
 import '../elements/entities.dart';
 import '../native/behavior.dart' show NativeBehavior;
 
 /// Basic information for native classes and methods and js-interop
 /// classes.
 ///
 /// This information is computed during loading using [NativeClassDataBuilder].
 abstract class NativeClassData {
   /// Returns `true` if [cls] corresponds to a native JavaScript class.
   ///
   /// A class is marked as native either through the `@Native(...)` annotation
   /// allowed for internal libraries or via the typed JavaScriptInterop
   /// mechanism allowed for user libraries.
   bool isNativeClass(ClassEntity element);
 
   /// Returns `true` if [element] or any of its superclasses is native.
   bool isNativeOrExtendsNative(ClassElement element);
 
-  /// Returns `true` if [element] corresponds to a native JavaScript member.
-  ///
-  /// A member is marked as native either through the native mechanism
-  /// (`@Native(...)` or the `native` pseudo keyword) allowed for internal
-  /// libraries or via the typed JavaScriptInterop mechanism allowed for user
-  /// libraries.
-  bool isNativeMember(MemberEntity element);
+  /// Returns `true` if [element] is a JsInterop library.
+  bool isJsInteropLibrary(LibraryElement element);

[Siggi Cherem (dart-lang), 2017/03/14 04:09:15]

couple random thoughts here: 
- maybe this means we need to rename NativeClassData to something else?
NativeDeclarationData? NativeBasicData?
- isJsInteropLibrary could also mean is this the "dart:js" library or is this
the "package:js" library... The dartdoc clarifies this, so I don't think we need
to change it, but might be good to have this ambiguity in mind.

[Johnni Winther, 2017/03/15 10:55:13]

Acknowledged.

 
   /// Returns `true` if [element] is a JsInterop class.
   bool isJsInteropClass(ClassElement element);
 }
 
 /// Additional element information for native classes and methods and js-interop
 /// methods.
 ///
 /// This information is computed during resolution using [NativeDataBuilder].
 abstract class NativeData extends NativeClassData {
+  /// Returns `true` if [element] corresponds to a native JavaScript member.
+  ///
+  /// A member is marked as native either through the native mechanism
+  /// (`@Native(...)` or the `native` pseudo keyword) allowed for internal
+  /// libraries or via the typed JavaScriptInterop mechanism allowed for user
+  /// libraries.
+  bool isNativeMember(MemberEntity element);
+
   /// Returns the [NativeBehavior] for calling the native [method].
   NativeBehavior getNativeMethodBehavior(MethodElement method);
 
   /// Returns the [NativeBehavior] for reading from the native [field].
   NativeBehavior getNativeFieldLoadBehavior(FieldElement field);
 
   /// Returns the [NativeBehavior] for writing to the native [field].
   NativeBehavior getNativeFieldStoreBehavior(FieldElement field);
 
   /// Returns `true` if the name of [element] is fixed for the generated
   /// JavaScript.
   bool hasFixedBackendName(Element element);
 
   /// Computes the name for [element] to use in the generated JavaScript. This
   /// is either given through a native annotation or a js interop annotation.
   String getFixedBackendName(Entity entity);
 
   /// Returns the list of non-directive native tag words for [cls].
   List<String> getNativeTagsOfClass(ClassElement cls);
 
   /// Returns `true` if [cls] has a `!nonleaf` tag word.
   bool hasNativeTagsForcedNonLeaf(ClassElement cls);
 
   /// Returns `true` if [element] is part of JsInterop.
+  ///
+  /// Deprecated: Use [isJsInteropLibrary], [isJsInteropClass] or
+  /// [isJsInteropMember] instead.
+  @deprecated
   bool isJsInterop(Element element);
 
   /// Returns `true` if [element] is a JsInterop method.
-  bool isJsInteropMethod(MethodElement element);
+  bool isJsInteropMember(MethodElement element);
 
   /// Returns the explicit js interop name for [element].
   String getJsInteropName(Element element);
 
   /// Apply JS$ escaping scheme to convert possible escaped Dart names into
   /// JS names.
   String getUnescapedJSInteropName(String name);
 }
 
 abstract class NativeClassDataBuilder {
   /// Sets the native tag info for [cls].
   ///
   /// The tag info string contains comma-separated 'words' which are either
   /// dispatch tags (having JavaScript identifier syntax) and directives that
   /// begin with `!`.
   void setNativeClassTagInfo(ClassElement cls, String tagInfo);
 
-  /// Returns the list of native tag words for [cls].
-  List<String> getNativeTagsOfClassRaw(ClassElement cls);
+  /// Marks [element] as an explicit part of JsInterop. The js interop name is
+  /// expected to be computed later.
+  void markAsJsInteropLibrary(LibraryElement element);
 
-  /// Sets the native [name] for the member [element]. This name is used for
-  /// [element] in the generated JavaScript.
-  void setNativeMemberName(MemberElement element, String name);
-
-  /// Returns [element] as an explicit part of JsInterop. The js interop name is
+  /// Marks [element] as an explicit part of JsInterop. The js interop name is
   /// expected to be computed later.
-  void markAsJsInterop(Element element);
-
-  /// Sets the explicit js interop [name] for [element].
-  void setJsInteropName(Element element, String name);
+  void markAsJsInteropClass(ClassElement element);
 }
 
 abstract class NativeDataBuilder {
   /// Registers the [behavior] for calling the native [method].
   void setNativeMethodBehavior(MethodElement method, NativeBehavior behavior);
 
   /// Registers the [behavior] for reading from the native [field].
   void setNativeFieldLoadBehavior(FieldElement field, NativeBehavior behavior);
 
   /// Registers the [behavior] for writing to the native [field].
   void setNativeFieldStoreBehavior(FieldElement field, NativeBehavior behavior);
+
+  /// Returns the list of native tag words for [cls].
+  List<String> getNativeTagsOfClassRaw(ClassElement cls);
+
+  /// Returns [element] as an explicit part of JsInterop. The js interop name is
+  /// expected to be computed later.
+  void markAsJsInteropMember(MemberElement element);
+
+  /// Sets the native [name] for the member [element]. This name is used for
+  /// [element] in the generated JavaScript.
+  void setNativeMemberName(MemberElement element, String name);
+
+  /// Sets the explicit js interop [name] for [element].
+  void setJsInteropName(Element element, String name);
 }
 
 class NativeDataImpl
     implements NativeData, NativeDataBuilder, NativeClassDataBuilder {
   /// The JavaScript names for elements implemented via typed JavaScript
   /// interop.
   Map<Element, String> jsInteropNames = <Element, String>{};
 
   /// The JavaScript names for native JavaScript elements implemented.
   Map<Element, String> nativeMemberName = <Element, String>{};
@@ skipping 16 matching lines @@
 
   /// Prefix used to escape JS names that are not valid Dart names
   /// when using JSInterop.
   static const String _jsInteropEscapePrefix = r'JS$';
 
   /// Returns `true` if [element] is explicitly marked as part of JsInterop.
   bool _isJsInterop(Element element) {
     return jsInteropNames.containsKey(element.declaration);
   }
 
-  /// Returns [element] as an explicit part of JsInterop. The js interop name is
+  /// Marks [element] as an explicit part of JsInterop. The js interop name is
   /// expected to be computed later.
   void markAsJsInterop(Element element) {
     jsInteropNames[element.declaration] = null;
   }
 
+  @override
+  void markAsJsInteropLibrary(LibraryElement element) {
+    markAsJsInterop(element);
+  }
+
+  @override
+  void markAsJsInteropClass(ClassElement element) {
+    markAsJsInterop(element);
+  }
+
+  @override
+  void markAsJsInteropMember(MemberElement element) {
+    markAsJsInterop(element);
+  }
+
   /// Sets the explicit js interop [name] for [element].
   void setJsInteropName(Element element, String name) {
     assert(invariant(element, isJsInterop(element),
         message:
             'Element $element is not js interop but given a js interop name.'));
     jsInteropNames[element.declaration] = name;
   }
 
   /// Returns the explicit js interop name for [element].
   String getJsInteropName(Element element) {
@@ skipping 11 matching lines @@
 
       if (_isJsInterop(function)) return true;
       if (function.isClassMember) return isJsInterop(function.contextClass);
       if (function.isTopLevel) return isJsInterop(function.library);
       return false;
     } else {
       return _isJsInterop(element);
     }
   }
 
+  /// Returns `true` if [element] is a JsInterop library.
+  bool isJsInteropLibrary(LibraryElement element) => isJsInterop(element);
+
   /// Returns `true` if [element] is a JsInterop class.
   bool isJsInteropClass(ClassElement element) => isJsInterop(element);
 
   /// Returns `true` if [element] is a JsInterop method.
-  bool isJsInteropMethod(MethodElement element) => isJsInterop(element);
+  bool isJsInteropMember(MethodElement element) => isJsInterop(element);
 
   /// Returns `true` if the name of [element] is fixed for the generated
   /// JavaScript.
   bool hasFixedBackendName(Element element) {
     return isJsInterop(element) ||
         nativeMemberName.containsKey(element.declaration);
   }
 
   String _jsNameHelper(Element element) {
     String jsInteropName = jsInteropNames[element.declaration];
@@ skipping 147 matching lines @@
   }
 
   /// Apply JS$ escaping scheme to convert possible escaped Dart names into
   /// JS names.
   String getUnescapedJSInteropName(String name) {
     return name.startsWith(_jsInteropEscapePrefix)
         ? name.substring(_jsInteropEscapePrefix.length)
         : name;
   }
 }