Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: pkg/compiler/lib/src/enqueue.dart

Issue 2732663002: Late creation of CodegenEnqueuer (Closed)
Patch Set: Remove eager creation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.enqueue; 5 library dart2js.enqueue;
6 6
7 import 'dart:collection' show Queue; 7 import 'dart:collection' show Queue;
8 8
9 import 'common/resolution.dart' show Resolution; 9 import 'common/resolution.dart' show Resolution;
10 import 'common/tasks.dart' show CompilerTask; 10 import 'common/tasks.dart' show CompilerTask;
11 import 'common/work.dart' show WorkItem; 11 import 'common/work.dart' show WorkItem;
12 import 'common.dart'; 12 import 'common.dart';
13 import 'compiler.dart' show Compiler; 13 import 'compiler.dart' show Compiler;
14 import 'options.dart'; 14 import 'options.dart';
15 import 'elements/elements.dart' 15 import 'elements/elements.dart'
16 show AnalyzableElement, ClassElement, MemberElement; 16 show AnalyzableElement, ClassElement, MemberElement;
17 import 'elements/entities.dart'; 17 import 'elements/entities.dart';
18 import 'elements/resolution_types.dart' show ResolutionTypedefType; 18 import 'elements/resolution_types.dart' show ResolutionTypedefType;
19 import 'elements/types.dart'; 19 import 'elements/types.dart';
20 import 'universe/world_builder.dart'; 20 import 'universe/world_builder.dart';
21 import 'universe/use.dart' 21 import 'universe/use.dart'
22 show DynamicUse, StaticUse, StaticUseKind, TypeUse, TypeUseKind; 22 show DynamicUse, StaticUse, StaticUseKind, TypeUse, TypeUseKind;
23 import 'universe/world_impact.dart' 23 import 'universe/world_impact.dart'
24 show ImpactStrategy, ImpactUseCase, WorldImpact, WorldImpactVisitor; 24 show ImpactStrategy, ImpactUseCase, WorldImpact, WorldImpactVisitor;
25 import 'util/enumset.dart'; 25 import 'util/enumset.dart';
26 import 'util/util.dart' show Setlet; 26 import 'util/util.dart' show Setlet;
27 import 'world.dart' show ClosedWorld;
27 28
28 class EnqueueTask extends CompilerTask { 29 class EnqueueTask extends CompilerTask {
29 ResolutionEnqueuer _resolution; 30 ResolutionEnqueuer _resolution;
30 Enqueuer _codegen;
31 final Compiler compiler; 31 final Compiler compiler;
32 32
33 String get name => 'Enqueue'; 33 String get name => 'Enqueue';
34 34
35 EnqueueTask(Compiler compiler) 35 EnqueueTask(Compiler compiler)
36 : this.compiler = compiler, 36 : this.compiler = compiler,
37 super(compiler.measurer) { 37 super(compiler.measurer) {
38 _resolution = new ResolutionEnqueuer( 38 _resolution = new ResolutionEnqueuer(
39 this, 39 this,
40 compiler.options, 40 compiler.options,
41 compiler.reporter, 41 compiler.reporter,
42 compiler.options.analyzeOnly && compiler.options.analyzeMain 42 compiler.options.analyzeOnly && compiler.options.analyzeMain
43 ? const DirectEnqueuerStrategy() 43 ? const DirectEnqueuerStrategy()
44 : const TreeShakingEnqueuerStrategy(), 44 : const TreeShakingEnqueuerStrategy(),
45 compiler.backend.resolutionEnqueuerListener, 45 compiler.backend.resolutionEnqueuerListener,
46 new ElementResolutionWorldBuilder( 46 new ElementResolutionWorldBuilder(
47 compiler.backend, compiler.resolution, const OpenWorldStrategy()), 47 compiler.backend, compiler.resolution, const OpenWorldStrategy()),
48 new ResolutionWorkItemBuilder(compiler.resolution)); 48 new ResolutionWorkItemBuilder(compiler.resolution));
49 _codegen = compiler.backend.createCodegenEnqueuer(this, compiler);
50 } 49 }
51 50
52 ResolutionEnqueuer get resolution => _resolution; 51 ResolutionEnqueuer get resolution => _resolution;
53 Enqueuer get codegen => _codegen; 52
53 Enqueuer createCodegenEnqueuer(ClosedWorld closedWorld) {
54 return compiler.backend.createCodegenEnqueuer(this, compiler);
55 }
54 } 56 }
55 57
56 abstract class Enqueuer { 58 abstract class Enqueuer {
57 WorldBuilder get worldBuilder; 59 WorldBuilder get worldBuilder;
58 ImpactStrategy get impactStrategy;
59 60
60 void open(ImpactStrategy impactStrategy, FunctionEntity mainMethod, 61 void open(ImpactStrategy impactStrategy, FunctionEntity mainMethod,
61 Iterable<LibraryEntity> libraries); 62 Iterable<LibraryEntity> libraries);
62 void close(); 63 void close();
63 64
64 /// Returns [:true:] if this enqueuer is the resolution enqueuer. 65 /// Returns [:true:] if this enqueuer is the resolution enqueuer.
65 bool get isResolutionQueue; 66 bool get isResolutionQueue;
66 67
67 bool queueIsClosed; 68 bool queueIsClosed;
68 69
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 @override 561 @override
561 WorkItem createWorkItem(MemberElement element) { 562 WorkItem createWorkItem(MemberElement element) {
562 assert(invariant(element, element.isDeclaration)); 563 assert(invariant(element, element.isDeclaration));
563 if (element.isMalformed) return null; 564 if (element.isMalformed) return null;
564 565
565 assert(invariant(element, element is AnalyzableElement, 566 assert(invariant(element, element is AnalyzableElement,
566 message: 'Element $element is not analyzable.')); 567 message: 'Element $element is not analyzable.'));
567 return _resolution.createWorkItem(element); 568 return _resolution.createWorkItem(element);
568 } 569 }
569 } 570 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698