Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2732633002: Remove Enqueuer.nativeEnqueuer (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Enqueuer.nativeEnqueuer - moves logic into the backend instead. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/22d499210160df6b9692d4acc79238c6aab66731

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -66 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 1 10 chunks +11 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 8 chunks +20 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 6 chunks +14 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 5 chunks +3 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 6 chunks +15 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-03 13:48:17 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2732633002/diff/1/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/2732633002/diff/1/pkg/compiler/lib/src/enqueue.dart#newcode137 pkg/compiler/lib/src/enqueue.dart:137: /// Called when to the queue is emptied. ...
3 years, 9 months ago (2017-03-14 03:10:50 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 22d499210160df6b9692d4acc79238c6aab66731 (presubmit successful).
3 years, 9 months ago (2017-03-15 09:02:46 UTC) #5
Johnni Winther
3 years, 9 months ago (2017-03-15 09:02:58 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2732633002/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2732633002/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:137: /// Called when to the queue is emptied.
On 2017/03/14 03:10:50, Siggi Cherem (dart-lang) wrote:
> mmm... "when to the"?

Good English not?

Powered by Google App Engine
This is Rietveld 408576698