Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: third_party/WebKit/Source/platform/audio/Reverb.h

Issue 2732523003: Make ConvolverNode conform to spec (Closed)
Patch Set: Remove unneeded numberOfChannels parameter and simplify code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/audio/Reverb.h
diff --git a/third_party/WebKit/Source/platform/audio/Reverb.h b/third_party/WebKit/Source/platform/audio/Reverb.h
index f29b8a42b624c4fc1b1c45fd26cfa76e77a31b6b..3fd2d9d1a621b0a956f2c0d31836244cc85d21f5 100644
--- a/third_party/WebKit/Source/platform/audio/Reverb.h
+++ b/third_party/WebKit/Source/platform/audio/Reverb.h
@@ -54,7 +54,6 @@ class PLATFORM_EXPORT Reverb {
Reverb(AudioBus* impulseResponseBuffer,
size_t renderSliceSize,
size_t maxFFTSize,
- size_t numberOfChannels,
bool useBackgroundThreads,
bool normalize);
@@ -70,10 +69,12 @@ class PLATFORM_EXPORT Reverb {
void initialize(AudioBus* impulseResponseBuffer,
size_t renderSliceSize,
size_t maxFFTSize,
- size_t numberOfChannels,
bool useBackgroundThreads);
size_t m_impulseResponseLength;
+ // The actual number of channels in the response. This can be less
+ // than the number of ReverbConvolver's in |m_convolvers|.
+ unsigned m_numberOfResponseChannels;
Vector<std::unique_ptr<ReverbConvolver>> m_convolvers;
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp ('k') | third_party/WebKit/Source/platform/audio/Reverb.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698