Issue 27324: Small fixes to allow all-in-one compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
11 years, 9 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Some small changes to allow the concatenation of all .cc files (in alphabetical order) to be compiled.

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	src/api.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/checks.cc	View	3 chunks	+10 lines, -12 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/interpreter-irregexp.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/v8.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Erik Corry

Does it lint? Does it still compile in the old way? LGTM.

11 years, 9 months ago (2009-03-02 08:49:35 UTC) #2

Erik Corry

It seems like this wasn't worth it after all. Should it be committed or closed?

11 years, 9 months ago (2009-03-20 09:33:55 UTC) #3

Christian Plesner Hansen

11 years, 9 months ago (2009-03-20 19:49:15 UTC) #4

Did I never submit this?  I'll take a look next week -- if the changes still
work I'll probably submit them, otherwise I'll close the issue.