ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc - Issue 2732333003: [Sync] ModelTypeStore factory shouldn't require valid PSS to function correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

Issue 2732333003: [Sync] ModelTypeStore factory shouldn't require valid PSS to function correctly (Closed)

Patch Set: Address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

diff --git a/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc b/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

index dd239c2663fd8bf54f8374ae060eab8ae1dc73f7..994243d576f22b8c6387eb121bcf6dd7f69b4451 100644

--- a/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

+++ b/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

@@ -142,11 +142,6 @@ IOSChromeProfileSyncServiceFactory::BuildServiceInstanceFor(

init_params.url_request_context = browser_state->GetRequestContext();

init_params.debug_identifier = browser_state->GetDebugName();

init_params.channel = ::GetChannel();

- base::SequencedWorkerPool* blocking_pool = web::WebThread::GetBlockingPool();

- init_params.blocking_task_runner =

- blocking_pool->GetSequencedTaskRunnerWithShutdownBehavior(

- blocking_pool->GetSequenceToken(),

- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);

auto pss = base::MakeUnique<ProfileSyncService>(std::move(init_params));