Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: components/sync/driver/sync_service_base.h

Issue 2732333003: [Sync] ModelTypeStore factory shouldn't require valid PSS to function correctly (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/driver/sync_client.h ('k') | components/sync/driver/sync_service_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/driver/sync_service_base.h
diff --git a/components/sync/driver/sync_service_base.h b/components/sync/driver/sync_service_base.h
index 8b6d1f8f66465de48b4c1a1297503102dd0495bc..fb902b0b75598d16564e491f61d5ec97fdb8d4b9 100644
--- a/components/sync/driver/sync_service_base.h
+++ b/components/sync/driver/sync_service_base.h
@@ -48,6 +48,16 @@ class SyncServiceBase : public SyncService, public SyncEngineHost {
void RemoveObserver(SyncServiceObserver* observer) override;
bool HasObserver(const SyncServiceObserver* observer) const override;
+ // Given base path (path to profile) formats path to "Sync Data" folder where
+ // sync engine stores directory database.
+ static base::FilePath FormatSyncDataPath(
+ const base::FilePath& base_directory);
+
+ // Given base path (path to profile) formats path to a folder containing
+ // ModelTypeStore's leveldb database.
+ static base::FilePath FormatSharedModelTypeStorePath(
+ const base::FilePath& base_directory);
+
protected:
// Notify all observers that a change has occurred.
void NotifyObservers();
@@ -87,11 +97,6 @@ class SyncServiceBase : public SyncService, public SyncEngineHost {
// information.
const base::FilePath base_directory_;
- // The full path to the sync data folder. The folder is not fully deleted when
- // sync is disabled, since it holds both Directory and ModelTypeStore data.
- // Directory files will be selectively targeted instead.
- const base::FilePath sync_data_folder_;
-
// An identifier representing this instance for debugging purposes.
const std::string debug_identifier_;
« no previous file with comments | « components/sync/driver/sync_client.h ('k') | components/sync/driver/sync_service_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698