Mojo cpp bindings: add support for validating incoming messages.

mojo/public/cpp/bindings/lib/interface_ptr_internal.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_INTERFACE_PTR_INTERNAL_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_INTERFACE_PTR_INTERNAL_H_
 
 #include <stdio.h>
 
+#include "mojo/public/cpp/bindings/lib/message_header_validator.h"
 #include "mojo/public/cpp/bindings/lib/router.h"
+#include "mojo/public/cpp/bindings/lib/validator_chain.h"
 
 namespace mojo {
 namespace internal {
 
 template <typename Interface>
 class InterfacePtrState {
  public:
   InterfacePtrState() : instance_(NULL), client_(NULL), router_(NULL) {}
 
   ~InterfacePtrState() {
@@ skipping 19 matching lines @@
     std::swap(other->instance_, instance_);
     std::swap(other->client_, client_);
     std::swap(other->router_, router_);
   }
 
   void ConfigureProxy(ScopedMessagePipeHandle handle,
                       MojoAsyncWaiter* waiter = GetDefaultAsyncWaiter()) {
     assert(!instance_);
     assert(!router_);
 
-    router_ = new Router(handle.Pass(), waiter);
+    internal::ValidatorChain validators;

[darin (slow to review), 2014/05/12 17:28:26]

nit: already in the internal namespace

[yzshen1, 2014/05/12 21:59:58]

Done.

+    validators.Append(new internal::MessageHeaderValidator)
+              .Append(new typename Interface::Client_::RequestValidator_)
+              .Append(new typename Interface::ResponseValidator_);
+
+    router_ = new Router(handle.Pass(), validators.Pass(), waiter);
     ProxyWithStub* proxy = new ProxyWithStub(router_);
     router_->set_incoming_receiver(&proxy->stub);
 
     instance_ = proxy;
   }
 
   void ConfigureStub(ScopedMessagePipeHandle handle,

[yzshen1, 2014/05/12 16:35:25]

I think this code is not used anymore, is it?

[darin (slow to review), 2014/05/12 17:28:26]

Whoops, yes. I meant to delete that function and the ClientProxyWithStub class.
Feel free to delete that in this CL.

[yzshen1, 2014/05/12 21:59:58]

Done.

                      MojoAsyncWaiter* waiter = GetDefaultAsyncWaiter()) {
     assert(instance_);  // Should have already been set!
     assert(!router_);
 
     // Stub for binding to state_.instance
     // Proxy for communicating to the client on the other end of the pipe.
 
-    router_ = new Router(handle.Pass(), waiter);
+    internal::ValidatorChain validators;
+    validators.Append(new internal::MessageHeaderValidator)
+              .Append(new typename Interface::RequestValidator_)
+              .Append(new typename Interface::Client_::ResponseValidator_);
+
+    router_ = new Router(handle.Pass(), validators.Pass(), waiter);
     ClientProxyWithStub* proxy = new ClientProxyWithStub(router_);
     proxy->stub.set_sink(instance_);
     router_->set_incoming_receiver(&proxy->stub);
 
     instance_->SetClient(proxy);
     client_ = proxy;
   }
 
  private:
   class ProxyWithStub : public Interface::Proxy_ {
@@ skipping 23 matching lines @@
   typename Interface::Client_* client_;
   Router* router_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(InterfacePtrState);
 };
 
 }  // namespace internal
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_INTERFACE_PTR_INTERNAL_H_