make input type="search" RTL direction aware

make input type="search" RTL direction aware.

Swap the positions of cancel button and search icon if dir="rtl".

BUG=232333
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160706

[pals, 2013-10-22 09:13:33]

Please review.

[ojan, 2013-10-24 22:10:46]

Levi, mind reviewing this? You know more about RTL than I.

[leviw_travelin_and_unemployed, 2013-10-24 23:21:48]

The code change is fine with one nit. You need to update the test, though, as
you're still clicking on the search icon, hence the "fail" at the bottom. I also
would like to see more info in the change description before landing.

https://codereview.chromium.org/27323002/diff/103001/Source/core/html/forms/S...
File Source/core/html/forms/SearchInputType.cpp (right):

https://codereview.chromium.org/27323002/diff/103001/Source/core/html/forms/S...
Source/core/html/forms/SearchInputType.cpp:99: if
(equalIgnoringCase(dirAttributeValue, "rtl")) {
nit: let's put ltr first since it's likely more common.

[pals, 2013-10-25 06:10:15]

Fixed the test. PTAL.

https://codereview.chromium.org/27323002/diff/103001/Source/core/html/forms/S...
File Source/core/html/forms/SearchInputType.cpp (right):

https://codereview.chromium.org/27323002/diff/103001/Source/core/html/forms/S...
Source/core/html/forms/SearchInputType.cpp:99: if
(equalIgnoringCase(dirAttributeValue, "rtl")) {
On 2013/10/24 23:21:49, Levi wrote:
> nit: let's put ltr first since it's likely more common.

Done.

[leviw_travelin_and_unemployed, 2013-10-25 18:22:47]

Perfect, thanks!

https://codereview.chromium.org/27323002/diff/203001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/resources/common.js (right):

https://codereview.chromium.org/27323002/diff/203001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/resources/common.js:107: pos.x = element.offsetLeft + 9;
Oh magic numbers... :(

[leviw_travelin_and_unemployed, 2013-10-25 18:22:57]

lgtm

[commit-bot: I haz the power, 2013-10-25 18:23:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/27323002/203001

[commit-bot: I haz the power, 2013-10-25 18:23:07]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 5.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
3cb4d2bd63783a41c3b3ff80a82995ac9ac18921..f23534c7472fad021e755483af644848750cc5dc
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -5,6 +5,7 @@ webkit.org/b/109400 [ Win ]
http/tests/css/css-image-loading.html [ Pass Timeout
 # This test can't just be rebaselined because it has absolute file paths in the
output.
 crbug.com/257132 http/tests/inspector/network/network-xhr-replay.html [ Failure
]
 
+crbug.com/232333 [ Win Mac ] fast/forms/search-rtl.html [ NeedsRebaseline ]
 crbug.com/247466 [ Win Debug ] inspector/debugger/live-edit-breakpoints.html [
Skip ]
 crbug.com/247466 [ Debug ] inspector/debugger/dom-breakpoints.html [ Skip ]
 crbug.com/247466 [ Debug ] inspector/debugger/xhr-breakpoints.html [ Skip ]

[commit-bot: I haz the power, 2013-10-28 08:03:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/27323002/303001

[commit-bot: I haz the power, 2013-10-28 09:02:02]

Change committed as 160706

[tkent, 2013-10-28 09:32:31]

This CL ignores the discussion in the bug, and the implementation is incorrect.
I'll revert it.

[tkent, 2013-10-28 10:17:08]

https://codereview.chromium.org/27323002/diff/303001/Source/core/html/forms/S...
File Source/core/html/forms/SearchInputType.cpp (right):

https://codereview.chromium.org/27323002/diff/303001/Source/core/html/forms/S...
Source/core/html/forms/SearchInputType.cpp:98: AtomicString dirAttributeValue =
element().fastGetAttribute(dirAttr);
This works only for <input type=search dir=rtl>, and doesn't work for <span
dir=rtl><input type=search></span>.

You should have removed the following ruleset in Source/css/html.css, and didn't
need to update any C++ code.

> input[type="search"]::-webkit-textfield-decoration-container {
>     direction: ltr;
> }

Anyway, such change doesn't work well on OSX.  We need a decision.