chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2732293003: Adding UMA on page load size for pages with Media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2732293003: Adding UMA on page load size for pages with Media (Closed)

Patch Set: bmcquade comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index ffca7008daa12fb5af7de0a9b2cb6b609782d498..2194083546eaf00460d57e8a4a8552e54f24076c 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -19,6 +19,7 @@

#include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"

#include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h"

@@ -79,8 +80,9 @@ void PageLoadMetricsEmbedder::RegisterObservers(

base::MakeUnique<google_captcha_observer::GoogleCaptchaObserver>());

tracker->AddObserver(

base::MakeUnique<DocumentWritePageLoadMetricsObserver>());

+ tracker->AddObserver(base::MakeUnique<MediaPageLoadMetricsObserver>());

tracker->AddObserver(

- base::WrapUnique(new previews::PreviewsPageLoadMetricsObserver()));

+ base::MakeUnique<previews::PreviewsPageLoadMetricsObserver>());

tracker->AddObserver(

base::MakeUnique<ServiceWorkerPageLoadMetricsObserver>());

tracker->AddObserver(base::MakeUnique<SubresourceFilterMetricsObserver>());