Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2094)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2732293003: Adding UMA on page load size for pages with Media (Closed)
Patch Set: bmcquade comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index c17e82e38f311363f16317409a654afc114abd60..e1d11c44100c728676e8ba562e7b7ca1b41c01fc 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -104,6 +104,22 @@ void MetricsWebContentsObserver::RenderViewHostChanged(
RegisterInputEventObserver(new_host);
}
+void MetricsWebContentsObserver::MediaStartedPlaying(
+ const content::WebContentsObserver::MediaPlayerInfo& video_type,
+ const content::WebContentsObserver::MediaPlayerId& id) {
+ content::RenderFrameHost* render_frame_host = id.first;
+ if (!render_frame_host->GetRenderViewHost() ||
+ render_frame_host->GetRenderViewHost()->GetMainFrame() !=
+ web_contents()->GetMainFrame()) {
+ // Ignore media that starts playing in a document that was navigated away
+ // from.
+ return;
+ }
+ if (committed_load_)
+ committed_load_->MediaStartedPlaying(
+ video_type, render_frame_host == web_contents()->GetMainFrame());
+}
+
bool MetricsWebContentsObserver::OnMessageReceived(
const IPC::Message& message,
content::RenderFrameHost* render_frame_host) {

Powered by Google App Engine
This is Rietveld 408576698