Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5347)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2732293003: Adding UMA on page load size for pages with Media (Closed)
Patch Set: Switching to WCO::MediaStartedPlaying instead of behavior flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
index 681e7cef03bfbe9b9fedf0c70416a535b9e503f9..a725db2b5c8a210e3f83313baea294bd166a063d 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
@@ -65,6 +65,9 @@ class MetricsWebContentsObserver
void RenderProcessGone(base::TerminationStatus status) override;
void RenderViewHostChanged(content::RenderViewHost* old_host,
content::RenderViewHost* new_host) override;
+ void MediaStartedPlaying(
Bryan McQuade 2017/03/14 00:24:06 do we know if this gets invoked for child frames?
RyanSturm 2017/03/16 00:06:24 Acknowledged.
+ const content::WebContentsObserver::MediaPlayerInfo& video_type,
+ const content::WebContentsObserver::MediaPlayerId& id) override;
// These methods are forwarded from the MetricsNavigationThrottle.
void WillStartNavigationRequest(content::NavigationHandle* navigation_handle);

Powered by Google App Engine
This is Rietveld 408576698