Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4146)

Unified Diff: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h

Issue 2732293003: Adding UMA on page load size for pages with Media (Closed)
Patch Set: self-review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..1e012310f2f36fb879e6a77ab3f3cf5ef19e91e6
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h
@@ -0,0 +1,53 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_MEDIA_PAGE_LOAD_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_MEDIA_PAGE_LOAD_METRICS_OBSERVER_H_
+
+#include <stdint.h>
+
+#include "base/macros.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+
+namespace page_load_metrics {
+struct PageLoadExtraInfo;
+struct PageLoadTiming;
+}
+
+// Observer responsible for recording metrics on pages that load at least one
mlamouri (slow - plz ping) 2017/03/13 18:38:27 By load, you really mean play I think.
RyanSturm 2017/03/13 23:38:24 Done.
+// MEDIA request.
+class MediaPageLoadMetricsObserver
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ MediaPageLoadMetricsObserver();
+ ~MediaPageLoadMetricsObserver() override;
+
+ // page_load_metrics::PageLoadMetricsObserver:
+ void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+ FlushMetricsOnAppEnterBackground(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnLoadedResource(
+ const page_load_metrics::ExtraRequestInfo& extra_request_info) override;
+ void OnLoadingBehaviorObserved(
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+
+ private:
+ // Records histograms for byte information.
+ void RecordByteHistograms();
+
+ // The number of body (not header) prefilter bytes consumed by requests for
+ // the page.
+ int64_t cache_bytes_;
+ int64_t network_bytes_;
+
+ // Whether the page load played a media element.
+ bool played_media_;
+
+ DISALLOW_COPY_AND_ASSIGN(MediaPageLoadMetricsObserver);
+};
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_MEDIA_PAGE_LOAD_METRICS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698