Adding UMA on page load size for pages with Media

chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f455f6acc25ae1498e714ca1e62ac1eefafca6bb
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
@@ -0,0 +1,125 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h"
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/test/histogram_tester.h"
+#include "base/time/time.h"
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/common/page_load_metrics/page_load_timing.h"
+#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
+#include "url/gurl.h"
+
+namespace {
+
+const char kDefaultTestUrl[] = "https://google.com";
+
+}  // namespace
+
+class MediaPageLoadMetricsObserverTest
+    : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ public:
+  MediaPageLoadMetricsObserverTest() {}
+  ~MediaPageLoadMetricsObserverTest() override {}
+
+  void ResetTest() {
+    // Reset to the default testing state. Does not reset histogram state.
+    timing_.navigation_start = base::Time::FromDoubleT(1);
+    timing_.response_start = base::TimeDelta::FromSeconds(2);
+    timing_.parse_start = base::TimeDelta::FromSeconds(3);
+    timing_.first_contentful_paint = base::TimeDelta::FromSeconds(4);
+    timing_.first_image_paint = base::TimeDelta::FromSeconds(5);
+    timing_.first_text_paint = base::TimeDelta::FromSeconds(6);
+    timing_.load_event_start = base::TimeDelta::FromSeconds(7);
+    PopulateRequiredTimingFields(&timing_);
+  }
+
+  void RunTest(bool simulate_play_media) {

[Charlie Harrison, 2017/03/08 14:33:58]

nit: I would prefer if this method was renamed "SimulatePageLoad", and the
histogram testers were moved to the the actual tests.

[RyanSturm, 2017/03/08 17:45:36]

Done.

+    NavigateAndCommit(GURL(kDefaultTestUrl));
+
+    page_load_metrics::PageLoadMetadata metadata;
+    if (simulate_play_media) {
+      metadata.behavior_flags |=
+          blink::WebLoadingBehaviorFlag::WebLoadingBehaviorMediaPlayed;
+    }
+    SimulateTimingAndMetadataUpdate(timing_, metadata);
+
+    // Prepare 4 resources of varying size and configurations.
+    page_load_metrics::ExtraRequestInfo resources[] = {
+        // Cached request.
+        {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+         false /* data_reduction_proxy_used*/,
+         0 /* original_network_content_length */},
+        // Uncached non-proxied request.
+        {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+         false /* data_reduction_proxy_used*/,
+         1024 * 40 /* original_network_content_length */},
+        // Uncached proxied request with .1 compression ratio.
+        {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+         false /* data_reduction_proxy_used*/,
+         1024 * 40 /* original_network_content_length */},
+        // Uncached proxied request with .5 compression ratio.
+        {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+         false /* data_reduction_proxy_used*/,
+         1024 * 40 /* original_network_content_length */},
+    };
+
+    int64_t network_bytes = 0;
+    int64_t cache_bytes = 0;
+    for (auto request : resources) {
+      SimulateLoadedResource(request);
+      if (!request.was_cached) {
+        network_bytes += request.raw_body_bytes;
+      } else {
+        cache_bytes += request.raw_body_bytes;
+      }
+    }
+
+    NavigateToUntrackedUrl();
+
+    if (!simulate_play_media) {
+      histogram_tester().ExpectTotalCount(
+          "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Network", 0);
+      histogram_tester().ExpectTotalCount(
+          "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Cache", 0);
+      histogram_tester().ExpectTotalCount(
+          "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Total", 0);
+    } else {
+      histogram_tester().ExpectUniqueSample(
+          "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Network",
+          static_cast<int>(network_bytes / 1024), 1);
+      histogram_tester().ExpectUniqueSample(
+          "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Cache",
+          static_cast<int>(cache_bytes / 1024), 1);
+      histogram_tester().ExpectUniqueSample(
+          "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Total",
+          static_cast<int>((network_bytes + cache_bytes) / 1024), 1);
+    }
+  }
+
+ protected:
+  void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+    tracker->AddObserver(base::MakeUnique<MediaPageLoadMetricsObserver>());
+  }
+
+ private:
+  page_load_metrics::PageLoadTiming timing_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaPageLoadMetricsObserverTest);
+};
+
+TEST_F(MediaPageLoadMetricsObserverTest, MediaPlayed) {
+  ResetTest();
+  RunTest(true /* simulate_play_media */);
+}
+
+TEST_F(MediaPageLoadMetricsObserverTest, MediaNotPlayed) {
+  ResetTest();
+  RunTest(false /* simulate_play_media */);
+}