Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: src/debug/arm64/debug-arm64.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/arm/debug-arm.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/arm64/debug-arm64.cc
diff --git a/src/debug/arm64/debug-arm64.cc b/src/debug/arm64/debug-arm64.cc
index 73e101be9a85234d673e205ce4558a30d4874b64..ae6bebf7be145945196bf6a3795ac9be33fea061 100644
--- a/src/debug/arm64/debug-arm64.cc
+++ b/src/debug/arm64/debug-arm64.cc
@@ -39,7 +39,7 @@ void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode) {
void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) {
- PatchingAssembler patcher(isolate, reinterpret_cast<Instruction*>(pc),
+ PatchingAssembler patcher(isolate, pc,
Assembler::kDebugBreakSlotInstructions);
EmitDebugBreakSlot(&patcher);
}
@@ -48,7 +48,7 @@ void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) {
void DebugCodegen::PatchDebugBreakSlot(Isolate* isolate, Address pc,
Handle<Code> code) {
DCHECK(code->is_debug_stub());
- PatchingAssembler patcher(isolate, reinterpret_cast<Instruction*>(pc),
+ PatchingAssembler patcher(isolate, pc,
Assembler::kDebugBreakSlotInstructions);
// Patch the code emitted by DebugCodegen::GenerateSlots, changing the debug
// break slot code from
« no previous file with comments | « src/debug/arm/debug-arm.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698