Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/arm64/instructions-arm64.h

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/code-stubs-arm64.h ('k') | src/arm64/instructions-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/instructions-arm64.h
diff --git a/src/arm64/instructions-arm64.h b/src/arm64/instructions-arm64.h
index db4e3d03a818420681c08196a80898ee1bf0ccbf..6110a14722bb304a9594b992a1731818127d501d 100644
--- a/src/arm64/instructions-arm64.h
+++ b/src/arm64/instructions-arm64.h
@@ -7,13 +7,13 @@
#include "src/arm64/constants-arm64.h"
#include "src/arm64/utils-arm64.h"
+#include "src/assembler.h"
#include "src/globals.h"
#include "src/utils.h"
namespace v8 {
namespace internal {
-
// ISA constants. --------------------------------------------------------------
typedef uint32_t Instr;
@@ -373,8 +373,9 @@ class Instruction {
bool IsTargetInImmPCOffsetRange(Instruction* target);
// Patch a PC-relative offset to refer to 'target'. 'this' may be a branch or
// a PC-relative addressing instruction.
- void SetImmPCOffsetTarget(Isolate* isolate, Instruction* target);
- void SetUnresolvedInternalReferenceImmTarget(Isolate* isolate,
+ void SetImmPCOffsetTarget(AssemblerBase::IsolateData isolate_data,
+ Instruction* target);
+ void SetUnresolvedInternalReferenceImmTarget(AssemblerBase::IsolateData,
Instruction* target);
// Patch a literal load instruction to load from 'source'.
void SetImmLLiteral(Instruction* source);
@@ -411,7 +412,8 @@ class Instruction {
static const int ImmPCRelRangeBitwidth = 21;
static bool IsValidPCRelOffset(ptrdiff_t offset) { return is_int21(offset); }
- void SetPCRelImmTarget(Isolate* isolate, Instruction* target);
+ void SetPCRelImmTarget(AssemblerBase::IsolateData isolate_data,
+ Instruction* target);
void SetBranchImmTarget(Instruction* target);
};
« no previous file with comments | « src/arm64/code-stubs-arm64.h ('k') | src/arm64/instructions-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698