Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/wasm/wasm-module.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-debug.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index dbacfb85dc1cd9446ff1b0075eee9c1d9aa45e27..ee87e8f84e802a4956de66e01997815c18d9e062 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -174,7 +174,8 @@ class JSToWasmWrapperCache {
if (target->kind() == Code::WASM_FUNCTION ||
target->kind() == Code::WASM_TO_JS_FUNCTION ||
target->builtin_index() == Builtins::kIllegal) {
- it.rinfo()->set_target_address(wasm_code->instruction_start());
+ it.rinfo()->set_target_address(target->GetIsolate(),
ahaas 2017/03/17 10:24:07 I think you could also just use {isolate}.
neis 2017/03/17 10:31:51 Acknowledged.
+ wasm_code->instruction_start());
break;
}
}
« no previous file with comments | « src/wasm/wasm-debug.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698