Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Side by Side Diff: src/x87/macro-assembler-x87.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/macro-assembler-x87.h ('k') | test/cctest/compiler/test-run-wasm-machops.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/division-by-constant.h" 8 #include "src/base/division-by-constant.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
11 #include "src/debug/debug.h" 11 #include "src/debug/debug.h"
12 #include "src/runtime/runtime.h" 12 #include "src/runtime/runtime.h"
13 #include "src/x87/frames-x87.h" 13 #include "src/x87/frames-x87.h"
14 #include "src/x87/macro-assembler-x87.h" 14 #include "src/x87/macro-assembler-x87.h"
15 15
16 namespace v8 { 16 namespace v8 {
17 namespace internal { 17 namespace internal {
18 18
19 // ------------------------------------------------------------------------- 19 // -------------------------------------------------------------------------
20 // MacroAssembler implementation. 20 // MacroAssembler implementation.
21 21
22 MacroAssembler::MacroAssembler(Isolate* arg_isolate, void* buffer, int size, 22 MacroAssembler::MacroAssembler(Isolate* isolate, void* buffer, int size,
23 CodeObjectRequired create_code_object) 23 CodeObjectRequired create_code_object)
24 : Assembler(arg_isolate, buffer, size), 24 : Assembler(arg_isolate, buffer, size),
25 generating_stub_(false), 25 generating_stub_(false),
26 has_frame_(false) { 26 has_frame_(false),
27 isolate_(isolate) {
27 if (create_code_object == CodeObjectRequired::kYes) { 28 if (create_code_object == CodeObjectRequired::kYes) {
28 code_object_ = 29 code_object_ =
29 Handle<Object>::New(isolate()->heap()->undefined_value(), isolate()); 30 Handle<Object>::New(isolate_->heap()->undefined_value(), isolate_);
30 } 31 }
31 } 32 }
32 33
33 34
34 void MacroAssembler::Load(Register dst, const Operand& src, Representation r) { 35 void MacroAssembler::Load(Register dst, const Operand& src, Representation r) {
35 DCHECK(!r.IsDouble()); 36 DCHECK(!r.IsDouble());
36 if (r.IsInteger8()) { 37 if (r.IsInteger8()) {
37 movsx_b(dst, src); 38 movsx_b(dst, src);
38 } else if (r.IsUInteger8()) { 39 } else if (r.IsUInteger8()) {
39 movzx_b(dst, src); 40 movzx_b(dst, src);
(...skipping 2715 matching lines...) Expand 10 before | Expand all | Expand 10 after
2755 mov(eax, dividend); 2756 mov(eax, dividend);
2756 shr(eax, 31); 2757 shr(eax, 31);
2757 add(edx, eax); 2758 add(edx, eax);
2758 } 2759 }
2759 2760
2760 2761
2761 } // namespace internal 2762 } // namespace internal
2762 } // namespace v8 2763 } // namespace v8
2763 2764
2764 #endif // V8_TARGET_ARCH_X87 2765 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/macro-assembler-x87.h ('k') | test/cctest/compiler/test-run-wasm-machops.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698