Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/x64/codegen-x64.h" 5 #include "src/x64/codegen-x64.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/macro-assembler.h" 10 #include "src/macro-assembler.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 MacroAssembler masm(isolate, buffer, static_cast<int>(actual_size), 43 MacroAssembler masm(isolate, buffer, static_cast<int>(actual_size),
44 CodeObjectRequired::kNo); 44 CodeObjectRequired::kNo);
45 // xmm0: raw double input. 45 // xmm0: raw double input.
46 // Move double input into registers. 46 // Move double input into registers.
47 __ Sqrtsd(xmm0, xmm0); 47 __ Sqrtsd(xmm0, xmm0);
48 __ Ret(); 48 __ Ret();
49 49
50 CodeDesc desc; 50 CodeDesc desc;
51 masm.GetCode(&desc); 51 masm.GetCode(&desc);
52 DCHECK(!RelocInfo::RequiresRelocation(desc)); 52 DCHECK(!RelocInfo::RequiresRelocation(isolate, desc));
53 53
54 Assembler::FlushICache(isolate, buffer, actual_size); 54 Assembler::FlushICache(isolate, buffer, actual_size);
55 base::OS::ProtectCode(buffer, actual_size); 55 base::OS::ProtectCode(buffer, actual_size);
56 return FUNCTION_CAST<UnaryMathFunctionWithIsolate>(buffer); 56 return FUNCTION_CAST<UnaryMathFunctionWithIsolate>(buffer);
57 } 57 }
58 58
59 #undef __ 59 #undef __
60 60
61 // ------------------------------------------------------------------------- 61 // -------------------------------------------------------------------------
62 // Code generators 62 // Code generators
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 return Operand(base_reg_, argument_count_reg_, times_pointer_size, 247 return Operand(base_reg_, argument_count_reg_, times_pointer_size,
248 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize); 248 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize);
249 } 249 }
250 } 250 }
251 251
252 252
253 } // namespace internal 253 } // namespace internal
254 } // namespace v8 254 } // namespace v8
255 255
256 #endif // V8_TARGET_ARCH_X64 256 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698