Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm64/code-generator-arm64.cc ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compilation-info.h" 7 #include "src/compilation-info.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 2196 matching lines...) Expand 10 before | Expand all | Expand 10 after
2207 int deoptimization_id, SourcePosition pos) { 2207 int deoptimization_id, SourcePosition pos) {
2208 DeoptimizeKind deoptimization_kind = GetDeoptimizationKind(deoptimization_id); 2208 DeoptimizeKind deoptimization_kind = GetDeoptimizationKind(deoptimization_id);
2209 DeoptimizeReason deoptimization_reason = 2209 DeoptimizeReason deoptimization_reason =
2210 GetDeoptimizationReason(deoptimization_id); 2210 GetDeoptimizationReason(deoptimization_id);
2211 Deoptimizer::BailoutType bailout_type = 2211 Deoptimizer::BailoutType bailout_type =
2212 deoptimization_kind == DeoptimizeKind::kSoft ? Deoptimizer::SOFT 2212 deoptimization_kind == DeoptimizeKind::kSoft ? Deoptimizer::SOFT
2213 : Deoptimizer::EAGER; 2213 : Deoptimizer::EAGER;
2214 Address deopt_entry = Deoptimizer::GetDeoptimizationEntry( 2214 Address deopt_entry = Deoptimizer::GetDeoptimizationEntry(
2215 isolate(), deoptimization_id, bailout_type); 2215 isolate(), deoptimization_id, bailout_type);
2216 if (deopt_entry == nullptr) return kTooManyDeoptimizationBailouts; 2216 if (deopt_entry == nullptr) return kTooManyDeoptimizationBailouts;
2217 __ RecordDeoptReason(deoptimization_reason, pos, deoptimization_id); 2217 if (isolate()->NeedsSourcePositionsForProfiling()) {
2218 __ RecordDeoptReason(deoptimization_reason, pos, deoptimization_id);
2219 }
2218 __ call(deopt_entry, RelocInfo::RUNTIME_ENTRY); 2220 __ call(deopt_entry, RelocInfo::RUNTIME_ENTRY);
2219 return kSuccess; 2221 return kSuccess;
2220 } 2222 }
2221 2223
2222 2224
2223 // The calling convention for JSFunctions on IA32 passes arguments on the 2225 // The calling convention for JSFunctions on IA32 passes arguments on the
2224 // stack and the JSFunction and context in EDI and ESI, respectively, thus 2226 // stack and the JSFunction and context in EDI and ESI, respectively, thus
2225 // the steps of the call look as follows: 2227 // the steps of the call look as follows:
2226 2228
2227 // --{ before the call instruction }-------------------------------------------- 2229 // --{ before the call instruction }--------------------------------------------
(...skipping 473 matching lines...) Expand 10 before | Expand all | Expand 10 after
2701 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2703 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2702 __ Nop(padding_size); 2704 __ Nop(padding_size);
2703 } 2705 }
2704 } 2706 }
2705 2707
2706 #undef __ 2708 #undef __
2707 2709
2708 } // namespace compiler 2710 } // namespace compiler
2709 } // namespace internal 2711 } // namespace internal
2710 } // namespace v8 2712 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm64/code-generator-arm64.cc ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698