Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Side by Side Diff: src/arm64/macro-assembler-arm64.cc

Issue 2732273003: Disentangle assembler from isolate. (Closed)
Patch Set: Address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.h ('k') | src/assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
11 #include "src/bootstrapper.h" 11 #include "src/bootstrapper.h"
12 #include "src/codegen.h" 12 #include "src/codegen.h"
13 #include "src/debug/debug.h" 13 #include "src/debug/debug.h"
14 #include "src/heap/heap-inl.h" 14 #include "src/heap/heap-inl.h"
15 #include "src/register-configuration.h" 15 #include "src/register-configuration.h"
16 #include "src/runtime/runtime.h" 16 #include "src/runtime/runtime.h"
17 17
18 #include "src/arm64/macro-assembler-arm64-inl.h" 18 #include "src/arm64/macro-assembler-arm64-inl.h"
19 #include "src/arm64/macro-assembler-arm64.h" // Cannot be the first include 19 #include "src/arm64/macro-assembler-arm64.h" // Cannot be the first include
20 20
21 namespace v8 { 21 namespace v8 {
22 namespace internal { 22 namespace internal {
23 23
24 // Define a fake double underscore to use with the ASM_UNIMPLEMENTED macros. 24 // Define a fake double underscore to use with the ASM_UNIMPLEMENTED macros.
25 #define __ 25 #define __
26 26
27 27 MacroAssembler::MacroAssembler(Isolate* isolate, byte* buffer,
28 MacroAssembler::MacroAssembler(Isolate* arg_isolate, byte* buffer,
29 unsigned buffer_size, 28 unsigned buffer_size,
30 CodeObjectRequired create_code_object) 29 CodeObjectRequired create_code_object)
31 : Assembler(arg_isolate, buffer, buffer_size), 30 : Assembler(isolate, buffer, buffer_size),
32 generating_stub_(false), 31 generating_stub_(false),
33 #if DEBUG 32 #if DEBUG
34 allow_macro_instructions_(true), 33 allow_macro_instructions_(true),
35 #endif 34 #endif
36 has_frame_(false), 35 has_frame_(false),
36 isolate_(isolate),
37 use_real_aborts_(true), 37 use_real_aborts_(true),
38 sp_(jssp), 38 sp_(jssp),
39 tmp_list_(DefaultTmpList()), 39 tmp_list_(DefaultTmpList()),
40 fptmp_list_(DefaultFPTmpList()) { 40 fptmp_list_(DefaultFPTmpList()) {
41 if (create_code_object == CodeObjectRequired::kYes) { 41 if (create_code_object == CodeObjectRequired::kYes) {
42 code_object_ = 42 code_object_ =
43 Handle<Object>::New(isolate()->heap()->undefined_value(), isolate()); 43 Handle<Object>::New(isolate_->heap()->undefined_value(), isolate_);
44 } 44 }
45 } 45 }
46 46
47 47
48 CPURegList MacroAssembler::DefaultTmpList() { 48 CPURegList MacroAssembler::DefaultTmpList() {
49 return CPURegList(ip0, ip1); 49 return CPURegList(ip0, ip1);
50 } 50 }
51 51
52 52
53 CPURegList MacroAssembler::DefaultFPTmpList() { 53 CPURegList MacroAssembler::DefaultFPTmpList() {
(...skipping 4602 matching lines...) Expand 10 before | Expand all | Expand 10 after
4656 } 4656 }
4657 4657
4658 4658
4659 #undef __ 4659 #undef __
4660 4660
4661 4661
4662 } // namespace internal 4662 } // namespace internal
4663 } // namespace v8 4663 } // namespace v8
4664 4664
4665 #endif // V8_TARGET_ARCH_ARM64 4665 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/macro-assembler-arm64.h ('k') | src/assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698