VM: [Kernel] Set DoubleInitializedBit on fields with double initializers.

VM: [Kernel] Set DoubleInitializedBit on fields with double initializers.

If this field is not set correctly then background compiler constantly bails
out when encoutering stores to these fields.

R=erikcorry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9bd34ef7858920bc500aa31c58ae8fc39bb64b99

[erikcorry, 2017-03-07 12:32:50]

lgtm

https://codereview.chromium.org/2732273002/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2732273002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:584: field.set_is_double_initialized(true);
Comment suggestion:
The field is initialized with a simple floating point value.
Emulate C++ parser by setting flag on field that helps the optimizer.

[Vyacheslav Egorov (Google), 2017-03-07 13:44:25]

Thanks

https://codereview.chromium.org/2732273002/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2732273002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:584: field.set_is_double_initialized(true);
On 2017/03/07 12:32:50, erikcorry wrote:
> Comment suggestion:
> The field is initialized with a simple floating point value.
> Emulate C++ parser by setting flag on field that helps the optimizer.

Added a comment

[Vyacheslav Egorov (Google), 2017-03-07 13:52:56]

Description was changed from

==========
VM: [Kernel] Set DoubleInitializedBit on fields with double initializers.

If this field is not set correctly then background compiler constantly bails
out when encoutering stores to these fields.

R=erikcorry@google.com
BUG=
==========

to

==========
VM: [Kernel] Set DoubleInitializedBit on fields with double initializers.

If this field is not set correctly then background compiler constantly bails
out when encoutering stores to these fields.

R=erikcorry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9bd34ef7858920bc500aa31c58ae8fc39bb64b99
==========

[Vyacheslav Egorov (Google), 2017-03-07 13:52:58]

Committed patchset #1 (id:1) manually as
9bd34ef7858920bc500aa31c58ae8fc39bb64b99 (presubmit successful).