Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: components/ntp_snippets/user_classifier.h

Issue 2732243002: [UserClassifier] Fix the classification for M58 condensed NTP experiment (Closed)
Patch Set: Comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/user_classifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/user_classifier.h
diff --git a/components/ntp_snippets/user_classifier.h b/components/ntp_snippets/user_classifier.h
index 4f8c9848d62d30e16e7ab678d7e56e1114389e7b..477e23ac760d1c3b9704e2292f8e0bd0b9e06901 100644
--- a/components/ntp_snippets/user_classifier.h
+++ b/components/ntp_snippets/user_classifier.h
@@ -41,6 +41,8 @@ class UserClassifier {
enum class Metric {
NTP_OPENED, // When the user opens a new NTP - this indicates potential
// use of content suggestions.
+ // TODO(jkrcal): Remove the following metric as for condensed NTP / Chrome
+ // Home, this coincides with NTP_OPENED.
SUGGESTIONS_SHOWN, // When the content suggestions are shown to the user -
// in the current implementation when the user scrolls
// below the fold.
@@ -98,7 +100,7 @@ class UserClassifier {
const double max_hours_;
// Params of the classification.
- const double active_consumer_scrolls_at_least_once_per_hours_;
+ const double active_consumer_clicks_at_least_once_per_hours_;
const double rare_user_opens_ntp_at_most_once_per_hours_;
DISALLOW_COPY_AND_ASSIGN(UserClassifier);
« no previous file with comments | « no previous file | components/ntp_snippets/user_classifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698