chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc - Issue 273223002: views: Make view::Views::GetPreferredSize() const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

Issue 273223002: views: Make view::Views::GetPreferredSize() const. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More compile fix for ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

index b76c1f68483f1338d574448ba3727102fe22baf8..a9862411e24540c7c7e2366c8926539bdb934d7d 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

@@ -48,10 +48,10 @@ BookmarkBarInstructionsView::BookmarkBarInstructionsView(

}

-gfx::Size BookmarkBarInstructionsView::GetPreferredSize() {

+gfx::Size BookmarkBarInstructionsView::GetPreferredSize() const {

int ascent = 0, descent = 0, height = 0, width = 0;

for (int i = 0; i < child_count(); ++i) {

- views::View* view = child_at(i);

+ const views::View* view = child_at(i);

gfx::Size pref = view->GetPreferredSize();

int baseline = view->GetBaseline();

if (baseline != -1) {